From 2c6a345039ef009e264660ce45f20df398566dda Mon Sep 17 00:00:00 2001 From: Sergey Tsepodoy Date: Thu, 25 Jul 2024 10:14:43 +0500 Subject: [PATCH 1/2] fix: fix links in pr-review-process --- docs/en/pull-request-review-process.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/en/pull-request-review-process.md b/docs/en/pull-request-review-process.md index fd41592..b611710 100644 --- a/docs/en/pull-request-review-process.md +++ b/docs/en/pull-request-review-process.md @@ -2,8 +2,8 @@ 1. A student completes an assignment in a school's private repository (unless otherwise specified in a task description). 2. The student creates and submits a Pull Request before the deadline. - - The PR rules are specified [below](https://docs.app.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) - - Penalties for deadline violations are listed [below](https://docs.app.rs.school/#/pull-request-review-process?id=Deadlines-for-Students) + - The PR rules are specified [below](https://docs.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) + - Penalties for deadline violations are listed [below](https://docs.rs.school/#/pull-request-review-process?id=Deadlines-for-Students) 3. Until the final grade is given by the mentor, the student can continue to implement remaining features 4. The mentor checks the PR, leaves his comments and recommendations on the quality of the code (copy-paste, magic numbers, project structure, etc.) and the implemented functionality. Leaves a comment with a preliminary score. - The score is set by the mentor based on the assessment criteria specified for each task @@ -38,7 +38,7 @@ Pull Request is a place to discuss contributor's code. It should not be a monolo ``` 1. Task: https://github.com/rolling-scopes-school/tasks/blob/master/tasks/fancy-weather.md 2. Screenshot: - ![](https://docs.app.rs.school/images/fancy-weather.png) + ![](https://docs.rs.school/images/fancy-weather.png) 3. Deployment: https://chakapega-fancy-weather.netlify.com/ 4. Done 28.05.2020 / deadline 31.05.2020 5. Score: 220 / 300 @@ -77,8 +77,8 @@ This approach solves several problems that are usually encountered when reviewin 1. Code Review process can be started with a check of the PR format, the naming of the commits, and a sufficient number of them. -- [Commit Requirements](https://docs.app.rs.school/#/git-convention) -- [Pull Request Requirements](https://https://docs.app.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) +- [Commit Requirements](https://docs.rs.school/#/git-convention) +- [Pull Request Requirements](https://https://docs.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) 2. Next, clone the repository, install dependencies, and check if the project is buildable / runnable. From f9370f6740b88b7316349439571a879d2f43fe27 Mon Sep 17 00:00:00 2001 From: Sergey Tsepodoy Date: Thu, 25 Jul 2024 16:50:05 +0500 Subject: [PATCH 2/2] fix: fix language version and anchoring in pr-review-process --- docs/en/pull-request-review-process.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/en/pull-request-review-process.md b/docs/en/pull-request-review-process.md index b611710..cf12f5f 100644 --- a/docs/en/pull-request-review-process.md +++ b/docs/en/pull-request-review-process.md @@ -2,8 +2,8 @@ 1. A student completes an assignment in a school's private repository (unless otherwise specified in a task description). 2. The student creates and submits a Pull Request before the deadline. - - The PR rules are specified [below](https://docs.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) - - Penalties for deadline violations are listed [below](https://docs.rs.school/#/pull-request-review-process?id=Deadlines-for-Students) + - The PR rules are specified [below](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following) + - Penalties for deadline violations are listed [below](https://docs.rs.school/#/en/pull-request-review-process?id=deadlines-for-students) 3. Until the final grade is given by the mentor, the student can continue to implement remaining features 4. The mentor checks the PR, leaves his comments and recommendations on the quality of the code (copy-paste, magic numbers, project structure, etc.) and the implemented functionality. Leaves a comment with a preliminary score. - The score is set by the mentor based on the assessment criteria specified for each task @@ -77,8 +77,8 @@ This approach solves several problems that are usually encountered when reviewin 1. Code Review process can be started with a check of the PR format, the naming of the commits, and a sufficient number of them. -- [Commit Requirements](https://docs.rs.school/#/git-convention) -- [Pull Request Requirements](https://https://docs.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following) +- [Commit Requirements](https://docs.rs.school/#/en/git-convention) +- [Pull Request Requirements](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following) 2. Next, clone the repository, install dependencies, and check if the project is buildable / runnable.