Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placekitten.com example in README fails to download images #415

Open
johnbradley opened this issue Mar 23, 2024 · 1 comment · May be fixed by #416
Open

placekitten.com example in README fails to download images #415

johnbradley opened this issue Mar 23, 2024 · 1 comment · May be fixed by #416

Comments

@johnbradley
Copy link

The Usage example in README fails to download files from placekitten with a 500 error. This seems to be a problem with placekitten and not img2dataset.

Example terminal session:

$ echo 'https://placekitten.com/200/305' >> myimglist.txt
$ echo 'https://placekitten.com/200/304' >> myimglist.txt
$ echo 'https://placekitten.com/200/303' >> myimglist.txt
$ img2dataset --url_list=myimglist.txt --output_folder=output_folder --thread_count=64 --image_size=256
Starting the downloading of this file
Sharding file number 1 of 1 called /Users/jpb67/Documents/work/img2dataset/sv/myimglist.txt
0it [00:00, ?it/s]File sharded in 1 shards
Downloading starting now, check your bandwidth speed (with bwm-ng)your cpu (with htop), and your disk usage (with iotop)!
1it [00:01,  1.67s/it]
worker  - success: 0.000 - failed to download: 1.000 - failed to resize: 0.000 - images per sec: 17 - count: 3
total   - success: 0.000 - failed to download: 1.000 - failed to resize: 0.000 - images per sec: 17 - count: 3

The output folder shows a 500 error.

 cat output_folder/00000_stats.json
{
    "count": 3,
    "successes": 0,
    "failed_to_download": 3,
    "failed_to_resize": 0,
    "duration": 0.17735910415649414,
    "start_time": 1711191984.052072,
    "end_time": 1711191984.2294312,
    "status_dict": {
        "HTTP Error 500: Internal Server Error": 3
    }
}

Browsing to https://placekitten.com/200/305 I get the following error:
placekitten-500-error

I didn't see a way to report this problem to placekitten.

I swapped placekitten.com for picsum.photos and everything ran as expected.
I could create a PR with a fix to make this change to the README if you like.

@rom1504
Copy link
Owner

rom1504 commented Mar 23, 2024 via email

johnbradley added a commit to johnbradley/img2dataset that referenced this issue Mar 23, 2024
Replaces placekitten.com example images with picsum.photos to  avoid 500 errors from placekitten.

Fixes rom1504#415
@johnbradley johnbradley linked a pull request Mar 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants