Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl plugin minifies source css #18

Open
szkrd opened this issue Jan 23, 2018 · 4 comments
Open

rtl plugin minifies source css #18

szkrd opened this issue Jan 23, 2018 · 4 comments

Comments

@szkrd
Copy link

szkrd commented Jan 23, 2018

I might be wrong, but it seems to me that the plugin minifes both files (the original and the rtlified version). Is this the desired behaviour?

@bimah
Copy link

bimah commented Jan 26, 2018

I am encountering the same issue. It seems like the plugin modify the original file too changing all the z-index properties.

The only workaround I could find is setting the minify: false, on the rtl-plugin
new WebpackRTLPlugin({ minify: false })

@szkrd
Copy link
Author

szkrd commented Jan 26, 2018

Yes, we never needed minify and it took us by surprise that the default is on (we minify stuff in our own pipeline). In fact since cssnano (unless configured differently) will modify keyframe names and this totally broke our css outputs...

@Abdelhady
Copy link

Minification could be helpful in general, except for what happens with z-index by cssnano. For me, I'm only disabling the overriding of the z-index like this:

new WebpackRTLPlugin({
    minify: {// Very important option to be passed to "cssnano" or it will override all z-index to be only '3' !
        zindex: false
    }
})

@saschask
Copy link

saschask commented Dec 3, 2019

Are there any updates on this? It seems like there are several problems with the webpack integration of this plugin. For example, I cannot imagine that it is expected behavior that the source file is manipulated (minified) by the RTL plugin. In addition, also source-maps are not working (see: #25). Thanks for any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants