From bc206368daa60920630b027c227ff787fbf4bb09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Mestres?= Date: Wed, 6 Mar 2024 18:01:13 +0100 Subject: [PATCH] restore lint & remove calciteWait log --- .github/workflows/ci.yml | 2 ++ tests/helpers/wait-calcite-ready.ts | 4 ++-- tests/integration/components/settings-form/font-test.ts | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c0cd2ed..c926ebe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,6 +15,8 @@ jobs: node-version: '18' - name: Install Dependencies run: yarn install --frozen-lockfile + - name: Lint + run: yarn lint - name: Test run: yarn test:ember - name: Visual Tests diff --git a/tests/helpers/wait-calcite-ready.ts b/tests/helpers/wait-calcite-ready.ts index ca387cc..40f0fdf 100644 --- a/tests/helpers/wait-calcite-ready.ts +++ b/tests/helpers/wait-calcite-ready.ts @@ -8,14 +8,14 @@ const TIME_SINCE_LAST_MUTATION = 1000; export default async function waitCalciteReady( opt: { timeout: number } = { timeout: MAX_TIMEOUT }, ) { - const start = new Date(); + // const start = new Date(); // This does not seems to work as expected await waitAllCalciteComponentReady(); // Use some workaround based on mutation observer to wait for page mutation end. await uiSettled(opt.timeout); - console.log('waitCalciteReady DONE', new Date().getTime() - start.getTime()); + // console.log('waitCalciteReady DONE', new Date().getTime() - start.getTime()); } async function waitAllCalciteComponentReady() { diff --git a/tests/integration/components/settings-form/font-test.ts b/tests/integration/components/settings-form/font-test.ts index cd0a7ae..024c53a 100644 --- a/tests/integration/components/settings-form/font-test.ts +++ b/tests/integration/components/settings-form/font-test.ts @@ -1,6 +1,6 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; -import { render, click, triggerEvent, settled, waitFor } from '@ember/test-helpers'; +import { render, click, triggerEvent, settled } from '@ember/test-helpers'; import { hbs } from 'ember-cli-htmlbars'; import { setComponentTemplate } from '@ember/component'; import { tracked } from '@glimmer/tracking';