New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show diff before and after 404 #1

Open

kcwu opened this issue Nov 18, 2013 · 1 comment

kcwu commented Nov 18, 2013

14:49 < kcwu> 話說 newsdiff 常看到新聞變 404 之後又變回來, 很奇怪
14:50 < kcwu> 可能要提供 ui 讓 user 看 404 前後的內文有沒有 diff

ronnywang added a commit that referenced this issue


          如果前一次是 404 就直接 regenerateInfo, 可以跳過 404 #1

b755cc8

Owner

ronnywang commented Jan 7, 2014

ok, 這個修好了
做了兩個變動

如果遇到非 200 的情況，會睡個 0.5 秒再重抓一次，最多抓三次，如果三次都是非 200 才會記錄下來非 200
如果上一次是 404 的話，會跳過 404 的修改記錄，但是如果是 404 結束的還是會保留

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment