Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to get data for only one or two days #32

Open
adamhsparks opened this issue Sep 15, 2021 · 2 comments
Open

Not possible to get data for only one or two days #32

adamhsparks opened this issue Sep 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@adamhsparks
Copy link
Member

adamhsparks commented Sep 15, 2021

This line checking the dates,

cond1 <- as.integer(xmax - xmin) > 1

works such that if I wanted to fetch data for 2015-01-15 - 2015-01-16 chirps will fail with the error message that the dates are out of sync with available data or that they are reversed (twisted).

@adamhsparks adamhsparks added the bug Something isn't working label Sep 15, 2021
@adamhsparks
Copy link
Member Author

adamhsparks commented Sep 15, 2021

It also means you can't fetch data for just one day as the value is 0. Checking for negative values instead should work.

@adamhsparks
Copy link
Member Author

adamhsparks commented Sep 15, 2021

@kauedesousa, I've implemented a fix. I'll write some tests to be sure that there aren't unintended side effects.

800ba70

@adamhsparks adamhsparks self-assigned this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant