Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Reset and Teleport robots service #20

Open
daenny opened this issue Jun 1, 2015 · 3 comments
Open

[Feature Request] Reset and Teleport robots service #20

daenny opened this issue Jun 1, 2015 · 3 comments

Comments

@daenny
Copy link

daenny commented Jun 1, 2015

Hi,
At the moment there is no possibility to move the robots in stage without GUI interaction or driving the robots around. It would be nice to have a "Teleport robot" service to move the robots anywhere on the map and I already implemented a "reset" service which resets the robots positions to the starting positions. This can be handy for running multiple experiments. (#19)
Cheers,
Daniel

@wjwwood
Copy link
Member

wjwwood commented Jun 1, 2015

Hi Daniel,

Thanks for the request, but realistically I won't have anytime to spend on this. If you or someone else is interested in opening a pull request then I'll happily work with them to get it merged and released.

@wjwwood wjwwood added this to the untargeted milestone Jun 1, 2015
@slremy
Copy link

slremy commented Dec 3, 2015

Please let me know if pull request #26 captures the requested feature.

@daenny
Copy link
Author

daenny commented Dec 3, 2015

Thanks for the update. I did not test yet, but from looking at your code, your approach should work. I guess I would prefer to have it as a service call, so that you cannot spam it and call it easily in your code with the check if it actually succeeded. One question is if there should be any checking if the given pose is actually "free space", so that you do not teleport robots into collision or outside the map.
So I like the approach you did with adding a new subscriber for each robot. I was always thinking a bit too complicated, since my idea was to create a single "teleport" service which takes in a robot name. Your approach is simpler and cleaner.
I would probably do it then like you did, but then instead of adding a Subscriber, I would add a service, that takes in a Pose2D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants