Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Specify the subscribed topic name in topic statistics #148

Open
3 tasks
snehaldb90 opened this issue Jun 12, 2020 · 0 comments
Open
3 tasks

Specify the subscribed topic name in topic statistics #148

snehaldb90 opened this issue Jun 12, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@snehaldb90
Copy link
Contributor

snehaldb90 commented Jun 12, 2020

Enhancement in #118

Now the SubscriberTopicStatisticsNode class subscribes to multiple topic for statistics collection.
However, we cannot distinguish for which topic the statistics are collected because the topic name is not specified in the statistics.

Description

Every statistic output should specify what topic it is a measurement of.

Test Plan

  • Manual testing
  • Unit test
  • Update e2e test

Documentation Plan

  • Docstrings

Release Plan

  • check in PR

Acceptance Criteria

  • Code has been implemented, reviewed and merged.
  • Test plan has been completed
  • Release plan has been completed

Once all above items are checked, this story can be moved to done.

Resources

Class to modify: SubscriberTopicStatistics

@emersonknapp emersonknapp added the bug Something isn't working label Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants