Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep record latch message when reset buffer #6

Open
jian-dong opened this issue Jul 22, 2020 · 11 comments
Open

keep record latch message when reset buffer #6

jian-dong opened this issue Jul 22, 2020 · 11 comments

Comments

@jian-dong
Copy link

Hello, Have any plan keep record latch message?

@DLu
Copy link
Collaborator

DLu commented Jul 23, 2020

I don't recall what the current behavior is. Do the latched messages fall out of the recording window?

@jian-dong
Copy link
Author

I see the code, when flush recording buffer, every message will be drop.

@Timple
Copy link
Contributor

Timple commented Jul 30, 2020

Looks like they are dropped.

A keep-last option would work for all topic types I guess. Or one has to inspect if it is a latched topic like so.

@Timple
Copy link
Contributor

Timple commented Jan 12, 2021

@jian-dong

Is this issue no longer relevant for you? For us it is (not highest prio at the moment though). Would you mind keeping it open 'for the record'?

@jian-dong jian-dong reopened this Jan 12, 2021
@jian-dong
Copy link
Author

@Timple Thank you for caring about this issue, now I use a temporary way be work around, just resend latch message when play bag.

@arneboe
Copy link

arneboe commented Jan 13, 2021

This issue is also relevant for us :-)
Right now we are still using a fork that I made when this was still a PR but eventually we would like to switch to upstream and this feature would be much appreciated.
Maybe I will get around to implement it in our branch and merge it upstream

@gavanderhoorn
Copy link

Related ROS Answers (I believe posted by @arneboe): Is it possible to know if a topic is latched on subscriber side in cpp.

@arneboe
Copy link

arneboe commented Jan 13, 2021

Related ROS Answers (I believe posted by @arneboe): Is it possible to know if a topic is latched on subscriber side in cpp.

yep that was me (sorry for the double post btw.).
I am implementing this right now in our fork and will hopefully provide a PR within the next week :-)

@Timple
Copy link
Contributor

Timple commented May 31, 2021

Another option would be to drop all connections and re-subscribe to all topics. All the latched topics would be send again.

Note: This might result in some message loss in-between bagfiles (we don't care).

@ayrton04
Copy link

+1. It seems like using the same logic we use here should work.

@eborghi10
Copy link
Contributor

You can just use this and it'll keep the first message:

- /tf_static:
    duration: -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants