Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill dangling subprocesses #632

Open
wants to merge 17 commits into
base: rolling
Choose a base branch
from
Open

Kill dangling subprocesses #632

wants to merge 17 commits into from

Commits on Dec 5, 2022

  1. Kill dangling subprocesses 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f86971a View commit details
    Browse the repository at this point in the history

  2. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    d268600 View commit details
    Browse the repository at this point in the history

  3. Fix docstring 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b5a925f View commit details
    Browse the repository at this point in the history

  4. Remove leftover comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    e2b1a3c View commit details
    Browse the repository at this point in the history

  5. Undo unneeded change 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    8466b49 View commit details
    Browse the repository at this point in the history

  6. Cleanup subprocesses before respawning 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2356223 View commit details
    Browse the repository at this point in the history

  7. please flake8 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ac6afd3 View commit details
    Browse the repository at this point in the history

  8. Fix issue detected in tests 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    7ffee9a View commit details
    Browse the repository at this point in the history

  9. Improve error handling 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6432d76 View commit details
    Browse the repository at this point in the history

  10. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6284c82 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary argument in __get_shutdown_timer_actions() 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    514c149 View commit details
    Browse the repository at this point in the history

  12. Add test case 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    5b43cdc View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Fix flake8 failures 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4b796cc View commit details
    Browse the repository at this point in the history

  2. More flake8 failures 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    58cd661 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Seems to fix CI issues... 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    5ff2f05 View commit details
    Browse the repository at this point in the history

  2. Second try 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    b5ba458 View commit details
    Browse the repository at this point in the history

  3. another try 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    fc97730 View commit details
    Browse the repository at this point in the history