-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 topic hz gives incorrect value with camera image #871
Comments
I think there's a debate to made here: I think there's little point for the tool if the |
@EwingKang as you mentioned already, this is the same with #719. that would be really appreciated if you consider the contribution. |
So, I think there are two different things here. The first problem is that The follow-up comment is about sending large amounts of data to a subscriber, just for that subscriber to throw it all away to count packets. I agree that it is fairly wasteful, though it isn't totally clear to me how we would avoid it. Possibly we could do so with some changes to the RMW layer/DDS implementations, but even then I'm not sure how we would do it. For now, I'm going to close this as a duplicate of ros2/ros2#1499 . If you disagree with that assessment, feel free to reopen. |
I have lost quite a bit of time due to this issue (thinking that my camera driver was not working correctly, when in fact it was just |
Just coming back to this issue to say that apparently setting up the DDS middleware to handle large amounts of data seems to fix the issue. |
@fdila i assumed that you were using
sounds reasonable. aligns with #719 (adding QoS settings for |
@fujitatomoya Hi, yes before cyclonedds I was using the default fastrtps. As you have seen in this other issue (ros2/rmw_fastrtps#739) I've tried playing around with this transport mechanism but I had not much luck with configuring fastrtps, I'll try your suggestion once I get back on my work PC. Anyway, I would assume that by configuring fastrtps "correctly" would fix the ros2 hz issue the same way that switching to cyclonedds. |
Bug report
Required Info:
ros2 topic hz
)Steps to reproduce issue
I'm using a Lenovo E16 laptop that comes with built-in camera
Expected behavior
Reporting 30 FPS
*The misspelling are purposely done to identify my modification to the installed package
Actual behavior
Reporting 15-22 FPS or even lower
*The misspelling are purposely done to identify my modification to the installed package
Additional information
Affecting source code: here
Following the hint from this answers.ros discussions, I try modifying the QoS setting directly in the installed location
/opt/ros/iron/lib/python3.10/site-packages/ros2topic/verb/hz.py
. By changing the qos profile line torclpy.qos.qos_profile_parameters
, it is possible forros2 topic hz
to report correct frequency.Expected value: 30 Hz as configured by the camera node
I believe the primary factor is the RELIABILITY_RELIABLE. This is because I can also replicate frame loss and thus image stutter in rviz2 image viewer if the reliability Policy is set to Best Effort.
This is related to : #843, and might be alleviated with #719
The text was updated successfully, but these errors were encountered: