[humble] Handle unsupported serialization formats in rosbag2's. #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files are scanned for the first support format. All other topics are ignored and the user is informed. Signed-off-by: Jesper Smith <[email protected]>
jespersmith
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
jespersmith
changed the title
jespersmith
changed the title
Signed-off-by: Jesper Smith <[email protected]>
|
I got a branch for rolling, but haven't had the time to test it yet (still on Ubuntu 22.04/Humble). |
Signed-off-by: Jesper Smith <[email protected]>
Signed-off-by: Jesper Smith <[email protected]>
Signed-off-by: Jesper Smith <[email protected]>
jespersmith
force-pushed
the
feature/support-unsupported-serialization-formats
branch
from
8ecba18
to
6e50655
Compare
Signed-off-by: Jesper Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue
This PR allows ros2 bag play to playback rosbags that have unsupported topics inside.
The implementation finds the first topic with a supported format, and ignores all other topics.
Currently based on humble, as that unblocks us immediately. Once the general approach is approved, we can rebase onto rolling.