fixed compilation issues for the backport to humble of issue 1842 #1860
+17
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clemens Mühlbacher <[email protected]>
cmuehlbacher
requested review from
emersonknapp and
jhdcs
and removed request for
a team
|
This should fix the compilation problems in #1850 |
fujitatomoya
requested changes
Nov 21, 2024
There was a problem hiding this comment.
overall lgtm, but missing DCO: https://github.com/ros2/rosbag2/pull/1860/checks?check_run_id=33324746330
Signed-off-by: Clemens Mühlbacher <[email protected]>
cmuehlbacher
force-pushed
the
mergify/bp/humble/pr-1842
branch
from
2175a6a
to
4b7244a
Compare
|
DCO is now fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the compilation problems with using time_stamp instead of recv_timestamp because recv_timestamp is not available in humble and time_stamp is set to the time of reception.
Removed any metadata checks in the tests as there is no callback for the updated metadata.
Fixed issues with using fs::path (Humble does not use std::fs)
Fixed issues within the tests to create topics (topic metadata is different from rolling)
Hopefully this will support the backport.