From 187a578ee55730f7a128a2f07b4351524b10d47b Mon Sep 17 00:00:00 2001 From: rosell-dk Date: Tue, 10 Nov 2020 12:24:50 +0100 Subject: [PATCH] added a comment --- src/Convert/Converters/GraphicsMagick.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/Convert/Converters/GraphicsMagick.php b/src/Convert/Converters/GraphicsMagick.php index fc24ebfd..f9543093 100644 --- a/src/Convert/Converters/GraphicsMagick.php +++ b/src/Convert/Converters/GraphicsMagick.php @@ -97,10 +97,18 @@ private function createCommandLineOptions() { $commandArguments = []; - // Unlike imagick binary, it seems gmagick binary uses a fixed - // quality (75) when quality is omitted + /* + if ($this->isQualityDetectionRequiredButFailing()) { + // Unlike imagick binary, it seems gmagick binary uses a fixed + // quality (75) when quality is omitted + // So we cannot simply omit in order to get same quality as source. + // But perhaps there is another way? + // Check out #91 - it is perhaps as easy as this: "-define jpeg:preserve-settings" + } + */ $commandArguments[] = '-quality ' . escapeshellarg($this->getCalculatedQuality()); + // encoding if ($this->options['encoding'] == 'lossless') { // Btw: