Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject laser_error in the script #28

Open
darkobozhinoski opened this issue Apr 12, 2021 · 3 comments
Open

Inject laser_error in the script #28

darkobozhinoski opened this issue Apr 12, 2021 · 3 comments
Assignees

Comments

@darkobozhinoski
Copy link
Contributor

darkobozhinoski commented Apr 12, 2021

We need to make a decision if we will kill the laser node to introduce the laser_error or we do the following:
(i) in the BASE system, we stop the run, immediately logging that the mission has failed;
(ii) in the MROS system, a message of a failure is reported to the Metacontrol, without actually killing the laser node.
If the laser node is killed, we can not measure the safety (observers report an error).

@marioney
Copy link
Member

@darkobozhinoski Should send the laser_error message also after 1/3 of the path?

@darkobozhinoski
Copy link
Contributor Author

It should be the same as the power increase timing.
You can choose the timing, it can be 1/3 or/and 2/3 for both: power increase and component failure.
Just reflect that in the Experiment Design.

@marioney
Copy link
Member

In b789873 I've added the -k option to the script.

It sends the laser error after 2/3 of the path have been completed (same as we did for the power increase failure)

Only one of the two are possible, (i.e. if the -k option is true, the power increase is disregarded)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants