Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings: coroutine 'ClientSession.close' was never awaited #175

Open
nicoddemus opened this issue Oct 1, 2018 · 0 comments
Open

Warnings: coroutine 'ClientSession.close' was never awaited #175

nicoddemus opened this issue Oct 1, 2018 · 0 comments
Labels
enhancement hacktoberfest

Comments

@nicoddemus
Copy link
Collaborator

I've seen this warnings in bottery's CI:

c:\projects\bottery\.tox\py35\lib\site-packages\bottery\bottery.py:107: RuntimeWarning: coroutine 'ClientSession.close' was never awaited
  self.session.close()
c:\projects\bottery\.tox\py35\lib\site-packages\bottery\bottery.py:107: RuntimeWarning: coroutine 'ClientSession.close' was never awaited
  self.session.close()

Seems like that line should be await self.session.close(), correct?
@justalemon justalemon mentioned this issue Oct 1, 2018
Closed
@rougeth rougeth mentioned this issue Oct 22, 2018
Closed
ivkalita added a commit to ivkalita/bottery that referenced this issue Oct 23, 2018
@ivkalita
rougeth#175: Changed Bottery.stop behavior.
4ddefff 
This patch fixes two problems in the Bottery.stop behavior:
1. self.session.close() was not awaited;
2. self.loop.close() causes an exception "Can not close running loop" in
some cases.
@ivkalita ivkalita mentioned this issue Oct 23, 2018
Closed
ivkalita added a commit to ivkalita/bottery that referenced this issue Oct 24, 2018
@ivkalita
rougeth#175: Trying to improve Bottery.stop once again.
2e557c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed ClientSession.close not being awaited
#175: Changed Bottery.stop behavior. ivkalita/bottery
1 participant
@nicoddemus