Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird border and foreground color for inactive modeline when in bottom position #56

Open
antrmn opened this issue Jun 5, 2023 · 6 comments

Comments

@antrmn
Copy link

antrmn commented Jun 5, 2023

I'm using Emacs 29.0.91 with nano-theme (master branch) and the simpler branch of the nano-modeline (but the same issue can be reproduced with the nano-modeline from the master branch).

This is how the modeline looks when on top:
Screenshot_20230605_174040

This is how it looks when on bottom:
Screenshot_20230605_174205

To reproduce this beheaviour, run this with emacs -Q:

(add-to-list 'load-path <path-to>/nano-theme")
(add-to-list 'load-path "<path-to>/nano-modeline")
(require 'nano-theme)
(require 'nano-modeline)
(load-theme 'nano t)
(setopt nano-modeline-position 'nano-modeline-footer)
(nano-modeline-text-mode t)
@rougier
Copy link
Owner

rougier commented Jun 19, 2023

Probably the mode-line-inactive face has some weird settings. Can you try to customize it and check how it is configured ?

@antrmn
Copy link
Author

antrmn commented Jun 19, 2023

These are the parameters of the mode-line-inactive face, as seen from the customization panel:

((t
  (:box
   (:line-width
    (3 . 3)
    :color "#90A4AE" :style nil)
   :foreground "#FFFFFF" :background "#90A4AE")))

These settings are the same whether i load nano-theme + nano-modeline or just nano-theme.

The same applies for the mode-line face:

((t
  (:box
   (:line-width
    (3 . 3)
    :color "#37474F" :style nil)
   :foreground "#FFFFFF" :background "#37474F")))

I believe the border issue can be solved by setting the following parameter for both mode-line and mode-line-inactive faces.

(:box (:line-width (3 . 3) :color nil :style flat-button)

This way the border gets the same color of the background.

As for the foreground color, both mode-line and mode-line-inactive have a white foreground (Set by nano-theme).

nano-modeline customizes its modeline using the following faces:

  • Active window modeline: nano-modeline-status + nano-modeline-active
  • Inactive window modeline: nano-modeline-inactive

nano-modeline-inactive does not have a configured foreground (unlike the other 2 faces), so the mode-line falls back to the white foreground from mode-line-inactive

@rougier
Copy link
Owner

rougier commented Jun 19, 2023

These defaults are probably saved in your custom settings (either at the end of your init.el file or in custom.el)

@antrmn
Copy link
Author

antrmn commented Jun 19, 2023

I have used "emacs -Q" when looking upon the face customization panel. This is the code that i fed to M-::

(add-to-list 'load-path <path-to>/nano-theme")
(add-to-list 'load-path "<path-to>/nano-modeline")
(require 'nano-theme)
(require 'nano-modeline)
(load-theme 'nano t)
(setopt nano-modeline-position 'nano-modeline-footer)
(nano-modeline-prog-mode t)

then I executed M-x customize. I believe no init.el or custom.file has been loaded

@rougier
Copy link
Owner

rougier commented Jun 19, 2023

Oh I see, the (3 . 3) comes from nano-theme. So best would be to set it to no box at all.

@antrmn
Copy link
Author

antrmn commented Jun 19, 2023

Also keeping the box with (3 . 3) but setting its color to nil would be an option, so that it wouldn't affect people who use nano-theme but not nano-modeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants