Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to master and tag it as done #1

Open
grgcombs opened this issue Apr 19, 2016 · 1 comment
Open

Merge develop to master and tag it as done #1

grgcombs opened this issue Apr 19, 2016 · 1 comment

Comments

@grgcombs
Copy link

The comments below may seem a little rambling, but the gist is that I'm glad to see you're still working on this project...

It baffles me that today I still see popular OS X / iOS reachability frameworks that inadvertently invoke many synchronous getFlags() calls. I would've thought everyone would've sorted all of that out by now ... or that Apple would've just pushed out a friendly framework of their own.

  • I still prefer your SCNetworkReachabilityKit for Objective-C work. In particular because it's clean, clear, and most importantly, it doesn't suffer from critical issues that others have.
  • Tony Million's Reachability is wildly popular but it is currently facing grave issues due to an unfortunate conflict with Apple's internal private framework audit/lookup during the App Store review process and he's on the fence about adopting a general namespace prefix. Additionally, his code still uses synchronous getFlags() !

Do you know of any outstanding issues with the development branch that need to be addressed before merging down to master and tagging it as a new release?

@royratcliffe
Copy link
Owner

Many thanks Greg for your feedback. Not a ramble at all. You encourage me to keep this project up-to-date.

Know what you mean about the synchronous call to getFlags(). It does seem counterintuitive. Why would anyone want to block the main thread?

Thanks for prefering SCNetworkReachabilityKit. Clean and clear was my original aim. Still is. I decided to include the synchronous getFlags() method for one reason only: because Apple's Foundation framework includes it. I figured that there must be some scenarios that require it, even though none come readily to mind.

There are no known issues with the current development branch. The changes are just Xcode-related issues. It now builds using Xcode 7. It currently builds with tests passing on 7.3. The project no longer builds a static library, since iOS now supports frameworks. I have a mind to release it as a CocoaPod, as I did for the Swift version of the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants