Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs: should be closeable by keydown #363

Open
rpbouman opened this issue Jan 7, 2025 · 1 comment
Open

Dialogs: should be closeable by keydown #363

rpbouman opened this issue Jan 7, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@rpbouman
Copy link
Owner

rpbouman commented Jan 7, 2025 •
edited
Loading

We can currently close dialogs with ESC, but it would be nice if each dialog button has a keyboard shortcut, for example, keypress Y would click the choose Yes button and close the dialog
@rpbouman rpbouman added the enhancement New feature or request label Jan 7, 2025
@rpbouman
Copy link
Owner Author

rpbouman commented Jan 18, 2025 •
edited
Loading

Actually, HTML already provides the accesskey attribute for that, maybe we should try that first.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

UPDATE; accesskey doesn't appear to do anything. But I suppose we should consider adding it when we do implement keyboard shortcuts for accessibility resasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpbouman