Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeUi: Local Day of week #371

Open
rpbouman opened this issue Jan 8, 2025 · 0 comments
Open

AttributeUi: Local Day of week #371

rpbouman opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@rpbouman
Copy link
Owner

rpbouman commented Jan 8, 2025

As it turns out, the structure of the week is localized.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getWeekInfo

This affects things like what is considered the first day of the week as well as what is considered a weekend.

Currently we do not take this into account, and when we choose day of week, we order them according to DuckDb's dayofweek, with sunday = 0, monday = 1, etc. (https://duckdb.org/docs/sql/functions/datepart#dayofweekdate)

Just like we have a derivation for the "local" version of date/time values, we should support that for the week. This would affect the ordering of the days

@rpbouman rpbouman added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant