Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Dynamic Spec part to create things needed earlier #2693

Closed
ffesti opened this issue Oct 4, 2023 · 0 comments · Fixed by #2917
Closed

Prevent Dynamic Spec part to create things needed earlier #2693

ffesti opened this issue Oct 4, 2023 · 0 comments · Fixed by #2917
Assignees
@ffesti
Labels
bug
Milestone
4.20.0

Comments

@ffesti
Copy link
Contributor

ffesti commented Oct 4, 2023 •
edited by pmatilai
Loading

As noted in #2646 dynamic spec parts can create/declare tags and sections that cannot be used that late and we should not allow that and error out. First rough list:

  • all build sections
    • including %generatebuildrequires
  • BuildRequires
  • BuildArch except sub-package noarch
@ffesti ffesti self-assigned this Oct 4, 2023
@ffesti ffesti added this to RPM Oct 4, 2023
@ffesti ffesti moved this to Todo in RPM Oct 4, 2023
@pmatilai pmatilai added the bug label Oct 4, 2023
@ffesti ffesti removed their assignment Oct 10, 2023
@pmatilai pmatilai added this to the 4.20.0 milestone Oct 10, 2023
@pmatilai pmatilai moved this from Todo to Priority in RPM Oct 25, 2023
@ffesti ffesti self-assigned this Nov 2, 2023
@ffesti ffesti moved this from Priority to In Progress in RPM Feb 16, 2024
ffesti added a commit to ffesti/rpm that referenced this issue Feb 19, 2024
@ffesti
No build directives in generated spec parts
55c12c3 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: rpm-software-management#2693
@ffesti ffesti mentioned this issue Feb 19, 2024
Merged
@ffesti ffesti moved this from In Progress to In Review in RPM Feb 19, 2024
ffesti added a commit to ffesti/rpm that referenced this issue Feb 27, 2024
@ffesti
No build directives in generated spec parts
b1eb415 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: rpm-software-management#2693
ffesti added a commit to ffesti/rpm that referenced this issue Feb 28, 2024
@ffesti
Don't allow build directives in generated specs
1e89c45 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: rpm-software-management#2693
@ffesti ffesti moved this from In Review to In Progress in RPM Mar 6, 2024
@pmatilai pmatilai moved this from In Progress to In Review in RPM Mar 6, 2024
ffesti added a commit to ffesti/rpm that referenced this issue Mar 6, 2024
@ffesti
Don't allow build directives in generated specs
8dcf882 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: rpm-software-management#2693
ffesti added a commit to ffesti/rpm that referenced this issue Mar 6, 2024
@ffesti
Don't allow build directives in generated specs
137a435 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: rpm-software-management#2693
pmatilai pushed a commit that referenced this issue Mar 7, 2024
@ffesti @pmatilai
Don't allow build directives in generated specs
1296ea9 
Many things need to be known before the build can be started. Make
declaring these sections or directives an error when encountered parsing
the generated Spec parts.

Resolves: #2693
@github-project-automation github-project-automation bot moved this from In Review to Done in RPM Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffesti ffesti

Labels
bug
Projects
RPM
Status: Done
Milestone
4.20.0
Development

Successfully merging a pull request may close this issue.

No build directives in generated spec parts ffesti/rpm
2 participants
@ffesti @pmatilai