[TASK] Improve styles of translation table #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevents scrollbar for textareas equal or less than two lines * Focus style follows extension colors * Rebuild css-table layout to grid and flex to prevent border collapsing with focus-styles Resolves: rrrapha#63
peter-neumann-dev
force-pushed
the
task/#63-improve-module-css
branch
from
ae16213
to
93e8d1d
Compare
|
Hi @rrrapha, do you think you would have time to take a look at this PR and maybe release a new version with the latest features like the sortOnSave option? We would be very happy to use it in our projects without patches or workarounds ✌🏻 |
rrrapha
added a commit
that referenced
this pull request
Jul 29, 2023
|
Thanks you @peter-neumann-dev, I have committed similar css changes according to your suggestions, are you ok with it? |
|
Hi @rrrapha, thank you! The changes seem to be good, like you committed them 👍🏻. I can test the issue with the outline thickness on a Full-HD screen when I am in the office next time. I have only retina by Apple at home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #63
@rrrapha I have polished the last styles a little bit to prevent inconsistent borders and focus styles that sometimes collapse on lower or special scaled resolutions. I got positive feedback from the last project where we worked with these adjustments.