update cssom package to rrweb self-owned package 'rrweb-cssom' #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
JSDOM/CSSOM is currently broken for one test case
should insert a rule at index [0,0] and keep existing rulesin rrdom package.@Juice10 has created a pull request for the official repository NV/CSSOM#113. Unfortunately, this PR hasn't been merged till now. So that the broken test case has to be always skipped.
Finally, we choose to fork and publish our own CSSOM package to work around.
https://github.com/rrweb-io/CSSOM
https://www.npmjs.com/package/rrweb-cssom
effect
Before this PR:
After the PR applied:
