Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngx-PHP7 Compilation improvements and Prebuilt modules #131

Open
soulteary opened this issue Aug 12, 2021 · 2 comments
Open

Ngx-PHP7 Compilation improvements and Prebuilt modules #131

soulteary opened this issue Aug 12, 2021 · 2 comments

Comments

@soulteary
Copy link
Contributor

soulteary commented Aug 12, 2021

I think this project is a very good project, so that Nginx can do a lot more.

However, it may be too long for the project to be submitted for testing by anyone other than the author, and the default project cannot be built.

For this I submitted a small improvement: #130

In order to use it more efficiently, I pre-built it: https://github.com/nginx-with-docker/ngx_http_php_module
And adjusted the build image and script, so that this module can be built locally with each newly launched version of nginx.

If the author thinks this method will be better, I can submit a PR with improved build image at a later date, like this: https://github.com/nginx-with-docker/ngx_http_php_module/blob/main/docker/master/Dockerfile.alpine

I believe this can greatly reduce the compilation problems encountered by various users. @rryqszq4

The image based on the latest code base can be downloaded from here:

docker pull soulteary/prebuilt-nginx-modules:ngx-1.21.1-php-master-alpine

If anyone has a need, I will add a pre-built image of the Debian version.

@jobs-git
Copy link

Pre built can be untrusted, what if add a check of version then autorecompile if needed?

@soulteary
Copy link
Contributor Author

No one has time to persecute you, especially based on open source code, you can always recreate the pre-built products yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants