Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password escaping with special characters #20

Open
luke-barnett opened this issue Sep 27, 2023 · 1 comment
Open

Password escaping with special characters #20

luke-barnett opened this issue Sep 27, 2023 · 1 comment

Comments

@luke-barnett
Copy link

I believe there is an issue with how passwords are currently being escaped, however, I don't fully understand how/why. We've found that some special characters cause an authentication failure when using the deploy task and the fix seems to be the use of double quotation marks over single quotation marks (as currently used).

It works but I don't understand enough to know why but if it's the solution I'm keen to get it upstream as currently our work around is to drop special characters from passwords which isn't ideal as you shouldn't have to worry about it.

I'll get a PR for this going shortly.

@luke-barnett
Copy link
Author

PR created #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant