Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on txid and txhash #16

Open
RedVelvetZip opened this issue Sep 30, 2024 · 1 comment
Open

Clarification on txid and txhash #16

RedVelvetZip opened this issue Sep 30, 2024 · 1 comment

Comments

@RedVelvetZip
Copy link

The transaction unique identifier is referred to as txhash / transaction hash everywhere except for the command to check transaction status

the following all refer to it as transaction hash
-transfer rBTC cli command
-deploy contract cli command
-block explorer frontend, which is linked out to in the output of the above commands

however the check transaction status cli command refers to this value a txid in it param field
rsk-cli tx --txid [0x...]

when a user executes a transfer/deployment, the terminal logs their txhash for them. then, if they want to then check on said tx status, they'd be asked for the txid, not the txhash. same value, under a different variable name

pretty minor, but the inconsistency may imply (to new users) that ID and Hash are distinct properties

@chrisarevalodev
Copy link
Collaborator

Hi @RedVelvetZip!

Thanks a lot for noticing about this detail. Your correct, that is a clear inconsistency that could lead to misunderstandings. Will take action on that on the next CLI update!

Thanks again and keep building 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants