Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze the Dot character #180

Closed
Fred-JulieDesk opened this issue Feb 8, 2016 · 4 comments
Closed

Freeze the Dot character #180

Fred-JulieDesk opened this issue Feb 8, 2016 · 4 comments

Comments

@Fred-JulieDesk
Copy link

Hello,

Would it be possible to freeze the "." character in the master release of this gem?

The memory allocation of this character greatly increase memory usage of some applications making extensive usage of translations.

Without freezing the character:
capture d ecran 2016-02-08 a 14 17 31

capture d ecran 2016-02-08 a 14 23 54

With the freezing:

capture d ecran 2016-02-08 a 14 25 08

With only this change in my application I have seen a decrease in the memory allocated of at least 5 MB (don't know if the displayed informations are in bits or bytes to be honest. I assumed it is in bits)

I wanted to perform a pull request but i can't figure out how to do it, so could you please do it yourself?
I am sure it would help lots of people who might not have even noticed this problem.

Have a nice day,

@Darep
Copy link

Darep commented Feb 10, 2016

Just happened to notice this issue while investigating some issues in our app and decided to give a helping hand with the pull request, see #181 :)

@Fred-JulieDesk
Copy link
Author

cool thx, can you explain me in a few words how you did the pull request from my fork?

ty,

@Fred-JulieDesk
Copy link
Author

i found it, nevermind

thx for the help

Have a nice day,

I close this issue

@Darep
Copy link

Darep commented Feb 10, 2016

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants