Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Cleanup #16

Merged
merged 12 commits into from
Oct 9, 2023
Merged

General Cleanup #16

merged 12 commits into from
Oct 9, 2023

Conversation

ToasterUwU
Copy link
Contributor

Cleaning up formatting issues, misspells, and other things my perfectionist brain cant leave standing.

@ToasterUwU
Copy link
Contributor Author

The last commit was mainly for the sake of the linebreaks not displaying at all on Github ( Needs an empty line to actually line break )

@ToasterUwU
style(setup.py): conform with PEP 8 styling
1b39024
@ToasterUwU
style(create_random_file.py): improve code readability by adding line…
b68d8ff 
… breaks and indentation for better clarity
@ToasterUwU
style(create_random_folder.py): PEP 8, sort imports, formatting
ef2983e
@ToasterUwU
style(plot_benchmark_results.py): improve code readability by formatt…
f858a7a 
…ing list and function arguments, PEP 8
@ToasterUwU
style(py3createtorrent.py): PEP 8, formatting for readability
a8b2418
@ToasterUwU
feat(plot_benchmark_results.py): add exception handling for empty Dat…
217a9c1 
…aFrame

refactor(plot_benchmark_results.py): remove unused stddev variable and related code
@ToasterUwU
refactor(py3createtorrent.py): replace include_md5 with md5 in condit…
3191903 
…ional checks, prevents lint errors about md5 being potentially unbound

fix(py3createtorrent.py): add type ignore comment to torrent_files argument in create_multi_file_info function call
@rsnitsch
Copy link
Owner

rsnitsch commented Oct 9, 2023

This project uses yapf for automatic code formatting. The code style for this project is defined in .style.yapf. The style is based on pep8, although a while back I added column_limit=120 which is a small deviation from pep8, but worth it IMHO.

Many formatting changes in this PR are unfortunately in conflict with the code style defined in .style.yapf, but this can be remedied easily by simply executing yapf on your changed code.

@ToasterUwU
Copy link
Contributor Author

Ran yapf ( that already was installed apparently ), did it with yapf -vv -r -i ., just so you know how I did it in case that matters and I didn't realize.

@ToasterUwU ToasterUwU mentioned this pull request Oct 9, 2023
Merged
@ToasterUwU ToasterUwU marked this pull request as ready for review October 9, 2023 19:43
@rsnitsch rsnitsch merged commit b23c911 into rsnitsch:develop Oct 9, 2023
2 checks passed
@rsnitsch
Copy link
Owner

rsnitsch commented Oct 9, 2023

Perfection. Thank you very much!

@ToasterUwU ToasterUwU deleted the refactor/general-cleanup branch October 9, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsnitsch rsnitsch Awaiting requested review from rsnitsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToasterUwU @rsnitsch