-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting workflow & Dependabot integration #17
Conversation
…push and pull requests
@rsnitsch Have a look, and feel free to merge if you are ok with this. I use this exact same thing in many of my Python projects, it helps a lot to minimize upkeep and also prevents many of the basic issues that can arise ( unbound vars, wrong types, etc. ) |
In case you arent familiar, everything used in here is free to use, so even tho this takes processing power, Github doesnt charge you for it. |
Just realized i need to change it to use pipenv instead ( I don't use that ) |
Very promising, thank you. |
feat(Pipfile): add pyright package to Pipfile
Ok, i have never used pipenv, i need to test it really quick on my fork, just to make sure it runs fine. After that you can merge it. |
Thank you for the extra diligence. 👌 |
… add virtualenv to path for pyright use
If you wonder which to merge first, doesn't really matter. The cleaner one would be to merge the other one first and then this one, but in the end of the day it will show "Lint Passed" as the newest status anyways. The actual PR for #13 I will make either tomorrow or the day after, depending on what else is on my list tommorow. |
Thank you very much! I merge this first because I want to see it screaming. ;-) |
@rsnitsch Btw, it might make sense to add all Python versions you want to officially support to the lint workflow. Just add them to the OS matrix thing next to 3.10 and 3.11. I recommend putting 3.8 in at least because that's pre-built-in type hinting. |
As promised in #13