Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging is slowing down execution #23

Open
chaseaucoin opened this issue Feb 6, 2021 · 1 comment
Open

Logging is slowing down execution #23

chaseaucoin opened this issue Feb 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@chaseaucoin
Copy link

The logging on every call takes a lot of time. Doing 10,000 request responses of static text "OK" takes 1.8426/ms per request which is abysmal for a 2 byte package. I see no clear options to disable this. If there is already a way to disable please let me know.

Expected Behavior

Ability to turn off logging

Actual Behavior

No ability to turn off logging (that I can see)

Steps to Reproduce

Follow the demo project, echo OK for 10,000 iterations

@Test
public void reproCase() {

}

Possible Solution

Provide ability to disable logging

Your Environment

  • RSocket version(s) used:
  • Other relevant libraries versions (eg. netty, ...):
  • Platform (eg. JVM version (javar -version) or Node version (node --version)):
  • OS and version (eg uname -a):
@OlegDokuka OlegDokuka added the enhancement New feature or request label Feb 6, 2021
@chaseaucoin
Copy link
Author

In RSocketProtocol.Handler.cs

updating static void Decoded(string message) => Console.WriteLine(message);
to
static void Decoded(string message) { }

improved speed from
1.8426/ms per request
to
0.2480/ms per request

But that still feels very slow for a local loopback for a 2 byte message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants