-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full subdocument result mode #56
Labels
Milestone
Comments
Tagging @V0ldek for notifications |
github-actions
bot
added
acceptance: go ahead
Reviewed, implementation can start
and removed
acceptance: triage
Waiting for owner's input
labels
Nov 25, 2022
V0ldek
added
type: feature
New feature or request
help wanted
External contributions welcome
acceptance: triage
Waiting for owner's input
mod: engine
area: result
Improvements in query result reporting
acceptance: go ahead
Reviewed, implementation can start
and removed
acceptance: go ahead
Reviewed, implementation can start
acceptance: triage
Waiting for owner's input
labels
Nov 25, 2022
V0ldek
added a commit
that referenced
this issue
Aug 2, 2023
This includes a revamp of all the internals that would be too long to describe in the log. In short: - `memmem` was rewritten to a custom implementation (courtesy of @charles-paperman) - Each of the result modes has a separate `Recorder` that takes care of producing the results - The results are written to a `Sink`, provided by the user; this might be a `Vec`, the stdout, or some other `io::Write` implementation. - Matches contain the full byte span of the value matched. - A lot of `Input` and classifier APIs have massive breaking changes to accomodate this. Ref: #56 Co-authored-by: cha <[email protected]>
github-project-automation
bot
moved this from Committed
to Merged
in Active rsonpath development
Aug 2, 2023
github-actions
bot
removed
the
acceptance: go ahead
Reviewed, implementation can start
label
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
We need the actual full result mode – output the entire subdocument that matches the query.
Describe the solution you'd like
Consider the query
$.a..b[*]
, and the JSON:Then in the output we should find all the following paths, separated with newlines:
Describe alternatives you've considered
Non-nested subdocument result mode tracked by #57
Additional context
This should be compatible with #54. Example output for the above JSON:
The text was updated successfully, but these errors were encountered: