Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should system prep verification use pkgbuild::check_build_tools()? #55

Open
batpigandme opened this issue Apr 22, 2019 · 0 comments
Open
Labels
radmin personal R administration

Comments

@batpigandme
Copy link
Contributor

batpigandme commented Apr 22, 2019

Currently the verify-system-prep section suggests using devtools::has_devel() to verify system readiness for development:
https://github.com/jennybc/what-they-forgot/blob/ec7696b21af2110e7f81262fd3cda8fd24c62e32/14_system-prep-for-build.Rmd#L63

The usethis setup vignette says:

  • pkgbuild::check_build_tools() is the most current function. It can be installed via install.packages("pkgbuild").
  • devtools::has_devel() was a function in devtools, at least up to v1.13.5, so you might still see references to that. All functionality related to package building now lives in pkgbuild. But once you have installed pkgbuild, you should just use the function pkgbuild::check_build_tools() instead.

Is it too soon to move to pkgbuild::check_build_tools() for the What They Forgot text? (If not, I'm happy to submit a PR).

I filed an issue for pkgbuild here re. possibility of returning something to signal success, but I'm thinking it might be better-suited as an usethis feature request…
r-lib/pkgbuild#73

@edavidaja edavidaja added the radmin personal R administration label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
radmin personal R administration
Projects
None yet
Development

No branches or pull requests

2 participants