Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the options parameter to settings to avoid confusion with selectize.js's terminology #4141

Open
dvg-p4 opened this issue Oct 10, 2024 · 0 comments

Comments

@dvg-p4
Copy link
Contributor

dvg-p4 commented Oct 10, 2024

The documentation for selectize.js refers to the things you can select as "options" and to the parameters that tweak rendering etc. as "settings".

Shiny's createSelectizeInput() and updateSelectizeInput() refer to the things you can select as "choices" and the javascript parameters as "options".

This conflict over what "options" means can be confusing. I suggest renaming the documented parameter to "settings" to match selectize's docs, but leaving options as an alias for backwards-compatibility.

@dvg-p4 dvg-p4 changed the title Rename the options parameter to settings for createSelectizeInput() and updateSelectizeInput() Rename the options parameter to settings to avoid confusion with selectize.js's terminology Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant