Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Remove some features in favor of the official pwa plugin #47

Open
4 tasks
pradeep910 opened this issue Dec 17, 2020 · 0 comments
Open
4 tasks

Remove some features in favor of the official pwa plugin #47

pradeep910 opened this issue Dec 17, 2020 · 0 comments
Assignees

Comments

@pradeep910
Copy link
Collaborator

With the latest official PWA plugin releasing we will get some features already in it.

Following work we need to do in PWA Extension to make it work well with official PWA plugin:

  • Remove "Add home to screen" work
  • Remove Assets caching feature
  • Remove Navigation caching feature
  • Add Code snippet to enable SVG files caching in uploaded images cache. (mostly we use SVG logos which don't get offline cached due to svg restriction)
add_filter( 'ext2type', static function ( $ext2type ) {
	$ext2type['image'][] = 'svg';
	return $ext2type;
} );

In our internal QA we found these issues:

  • Enabled both PWA main and rt PWA extension plugin and performed quick sanity and following are the observations.
  • If both plugins are active then Add to home screen is not appearing. If only PWA main plugin is active Add to home screen is appearing
  • Offline reading is working as expected
  • If both plugins are active then the Navigation cache and Uploaded images are not getting created.

image

@pradeep910 pradeep910 changed the title Features Remove some features in favor of the official pwa plugin Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants