-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Refactor] Reorganization of BERTrend code #17
Open
picaultj
wants to merge
40
commits into
main
Choose a base branch
from
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] [Refactor] Reorganization of BERTrend code #17
picaultj
wants to merge
40
commits into
main
from
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TopicModel class to encapsulate initialization and calls to topic models (BERTopic) - BERTrend class to encapsulate the main steps of the BERTrend algorithm - bertrend.toml config to configurate Embedding and LLM services - EmbeddingService to decide between local and remote embeddings - some tests (to be completed) - reorganization of files
- finalized LLM service configuration
2 tasks
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 18, 2024 12:14
e4c6a96
to
08752e3
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 19, 2024 12:47
228abb9
to
10cf9a5
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 19, 2024 13:33
96d393d
to
8a3c057
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 20, 2024 09:23
8e443f7
to
f78328d
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
3 times, most recently
from
December 21, 2024 13:17
bee0120
to
004fac9
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 21, 2024 13:19
004fac9
to
12eed54
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 22, 2024 13:51
fdda807
to
8a916af
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 23, 2024 10:22
f3b405e
to
4b44aca
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
2 times, most recently
from
December 30, 2024 16:25
83949ce
to
5202019
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 30, 2024 16:32
5202019
to
2035357
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 31, 2024 11:22
d0d84ba
to
169b9aa
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 31, 2024 11:39
169b9aa
to
020a994
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 31, 2024 17:27
51c7125
to
8c1c142
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
December 31, 2024 17:38
8c1c142
to
ccef0f4
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
January 2, 2025 13:40
4fa8ee0
to
9c73d7f
Compare
picaultj
force-pushed
the
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
branch
from
January 2, 2025 14:27
9c73d7f
to
7c1d5dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized code structure
TopicModel class to encapsulate initialization and calls to topic models (BERTopic)
BERTrend class to encapsulate the main steps of the BERTrend algorithm
bertrend.toml config to configurate Embedding and LLM services
EmbeddingService to decide between local and remote embeddings
Configuration of LLM service
some tests (to be completed)
Replaced configparser with toml files
Harmonization of data loading between prototypes and possibility to load local data
Refactoring demo 1 (topic analysis)
Admin mode to show/hide some parameters and results
Code cleaning
Adaptation of topic-based newsletter generation
more to come...