Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name for Jigsaw modules support #1329

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

madlexa
Copy link

@madlexa madlexa commented Mar 7, 2024

I am encountering a problem while attempting to use the telegrambots library in my project with Jigsaw modules. Maven generates a warning indicating that filename-based automatic modules are detected: [telegrambots-6.9.7.1.jar, telegrambots-meta-6.9.7.1.jar]. The warning strongly advises against publishing this project to a public artifact repository due to the use of automatic modules, which suggests that the telegrambots library lacks explicit module naming. This lack of explicit module naming prevents integration with Jigsaw modules, thereby hindering modularity in applications that utilize this library.

the error:

[WARNING] * Required filename-based automodules detected: [telegrambots-6.9.7.1.jar, telegrambots-meta-6.9.7.1.jar]. Please don't publish this project to a public artifact repository! *

@madlexa
Copy link
Author

madlexa commented Jun 7, 2024

@rubenlagus could you take a look at the commit?

@rubenlagus
Copy link
Owner

this MR is pre-version 7, will need some changes to be able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants