Dev #1458
Open
Dev #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aNNiMON
approved these changes
Nov 19, 2024
| @Override | ||
| public void validate() throws TelegramApiValidationException { | ||
| if (userId == 0) { | ||
| throw new TelegramApiValidationException("UserId parameters must not be 0", this); |
There was a problem hiding this comment.
UserId parameters
parameter shouldn't be plural
There was a problem hiding this comment.
There is an inconsistency in the user id validation messages. Probably a constant or even separate validator will be needed in the future to avoid such mistakes. I'll probably provide some PR later.
| */ | ||
| @JsonProperty(IS_CANCELLED_FIELD) | ||
| @NonNull | ||
| private Boolean isCancelled; |
There was a problem hiding this comment.
Both canceled and cancelled are acceptable, but since Bot API uses single 'l' character, isn't is better to stick to official parameter naming?
…1438) Co-authored-by: Ruben Bermudez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.