Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the transfer of RBT tokens between DIDs that are present on the same node #207

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Fixed the transfer of RBT tokens between DIDs that are present on the same node #207

merged 8 commits into from
Dec 26, 2024

Conversation

arnabghose997
Copy link
Collaborator

Closes #206 and follows the suggestion mentioned in the issue.

A test case has been added which covers the transfer of RBT between DIDs present on the same server

@arnabghose997
fixed transfer of RBT tokens between DIDs that are present on the sam…
369c383 
…e node by adding a validation rule to check for receiver's DID in DIDTable following the DIDPeerTable check
@arnabghose997 arnabghose997 self-assigned this Aug 6, 2024
@arnabghose997 arnabghose997 added the bug Something isn't working label Aug 6, 2024
@arnabghose997 arnabghose997 linked an issue Aug 6, 2024 that may be closed by this pull request
bug: Unable to transfer RBT between DIDs belonging to the same Node server #206
Open
@arnabghose997 arnabghose997 marked this pull request as draft August 9, 2024 08:42
@arnabghose997
Copy link
Collaborator Author

arnabghose997 commented Aug 12, 2024 •
edited
Loading

Covered the scenario where either the Sender or Receiver is present on a Quorum node. Briefly, the fix includes adding a condition inside updatePledgeToken function, where we only add the token chain block when neither the sender nor receiver are present on the Quorum node. This is done to resolve a situation where addition of block to the trans token can happen twice.

Tests have been written to cover these scenarios:

  • Transfer between DIDs, both present on same Non-Quorum Server
  • Transfer between DIDs, both present on same Quorum Server
  • Transfer between DIDs, both present on different Quorum Server
  • Transfer between DIDS, where the Sender is present on Quorum Server and Receiver is present on Non-Quorum Server
  • Transfer between DIDS, where the Sender is present on Non-Quorum Server and Receiver is present on Quorum Server

@arnabghose997 arnabghose997 marked this pull request as ready for review August 12, 2024 09:13
@arnabghose997 arnabghose997 linked an issue Aug 23, 2024 that may be closed by this pull request
Error while adding info to TokenStateHash table when 2 Quorum nodes belong to the same server #209
Open
@arnabghose997 arnabghose997 marked this pull request as draft August 23, 2024 07:02
@arnabghose997 arnabghose997 changed the title Fixed transfer of RBT tokens between DIDs that are present on the same node Fixed the transfer of RBT tokens between DIDs that are present on the same node Nov 1, 2024
@arnabghose997 arnabghose997 force-pushed the arnab/fix-transfer-between-self-dids branch from bdd3e3e to 9739751 Compare November 1, 2024 07:45
@arnabghose997 arnabghose997 removed a link to an issue Nov 1, 2024
Error while adding info to TokenStateHash table when 2 Quorum nodes belong to the same server #209
Open
@arnabghose997 arnabghose997 marked this pull request as ready for review November 11, 2024 04:59
@arnabghose997
Copy link
Collaborator Author

The Python tests for this PR has been run on a local MacOS system, and all tests pass successfully. Hence, the error MacOS Git workflow is associated with some Github VM issues

gklps
gklps approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@gklps gklps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnabghose997 arnabghose997 merged commit 9c568f0 into development Dec 26, 2024
2 of 3 checks passed
@arnabghose997 arnabghose997 deleted the arnab/fix-transfer-between-self-dids branch December 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gklps gklps gklps approved these changes

@thewebchap thewebchap Awaiting requested review from thewebchap

Assignees

@arnabghose997 arnabghose997

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Unable to transfer RBT between DIDs belonging to the same Node server
2 participants
@arnabghose997 @gklps