Cop idea: detect .none()

[ydakuka]

Actual behavior

I have the code:

module ApplicationHelper
  def my_method
    User.where(id: nil)
    User.where(id: 0)
    User.where(id: [])
    User.where(id: {})
    User.limit(nil)
    User.limit(0)
  end
end

I run rubocop and don't get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/helpers/application_helper.rb
Inspecting 1 file
.

1 file inspected, no offenses detected

Expected behavior

I expected to receive the following code:

module ApplicationHelper
  def my_method
    User.none # for all cases
  end
end

[koic]

This seems to be a matter of style. Please open a proposal in the style guide first. If accepted there, it can be provided as a cop.
https://github.com/rubocop/rails-style-guide

Note that while these will return the same results in most cases, they do not behave strictly the same.

[ydakuka]

rubocop/rails-style-guide#337