Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new options params to the mustermann grape pattern for taking into account the parameter type #20

Closed
jcagarcia opened this issue Nov 13, 2023 · 1 comment
Closed

Add new options params to the mustermann grape pattern for taking into account the parameter type #20

jcagarcia opened this issue Nov 13, 2023 · 1 comment

Comments

@jcagarcia
Copy link
Collaborator

Hi everyone 👋

From the conversation in ruby-grape/grape#2350 (comment)

I consider that adding the information from the params received when initialising the pattern class we can generate a much more precise regular expression.
jcagarcia added a commit to jcagarcia/mustermann-grape that referenced this issue Nov 13, 2023
@jcagarcia
fix(ruby-grape#20): Add params option to the mustermann grape patte…
600ab9e 
…rn for taking into account the parameter type
jcagarcia added a commit to jcagarcia/mustermann-grape that referenced this issue Nov 13, 2023
@jcagarcia
fix(ruby-grape#20): Add params option to the mustermann grape patte…
1abbb24 
…rn for taking into account the parameter type
jcagarcia added a commit to jcagarcia/mustermann-grape that referenced this issue Nov 13, 2023
@jcagarcia
fix(ruby-grape#20): Add params option to the mustermann grape patte…
b87430f 
…rn for taking into account the parameter type
@jcagarcia jcagarcia mentioned this issue Nov 13, 2023
Merged
jcagarcia added a commit to jcagarcia/mustermann-grape that referenced this issue Nov 15, 2023
@jcagarcia
fix(ruby-grape#20): Upgrade version to 1.1.0
f8b54ae
jcagarcia added a commit to jcagarcia/mustermann-grape that referenced this issue Nov 15, 2023
@jcagarcia
fix(ruby-grape#20): Run tests with Ruby 3.x
0d7acd7
dblock added a commit that referenced this issue Nov 24, 2023
@dblock
Merge pull request #21 from jcagarcia/issue-20
b656da3 
fix(#20): Add `params` option to the mustermann grape pattern for taking into account the parameter type
@jcagarcia
Copy link
Collaborator Author

Merged in #21 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcagarcia