Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Lrama::Grammar::Rule#to_s to Lrama::Grammar:Rule::display_name #426

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Rename Lrama::Grammar::Rule#to_s to Lrama::Grammar:Rule::display_name #426

merged 1 commit into from
Jun 2, 2024

Conversation

S-H-GAMELINKS
Copy link
Contributor

I saw a TODO in lib/lrama/grammar/rule.rb to rename the to_s method to the display_name method, so I renamed it.

ydah
ydah approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@ydah ydah merged commit a931061 into ruby:master Jun 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-H-GAMELINKS @ydah