Update partner request form to require at least 1 item

[joshleichtung]

Currently, a partner can make a request without actually including any items. There should probably be validations around this, both in the form and perhaps in the data model.

The above is a valid submission but should not be.

[Randond]

Hello, I am a student from Loyola, I would like to work on this issue. I cannot assign it to myself as we are only allowed to assign issues to ourselves that are in the Loyno team. As a result, I will make a copy of the issue over there and be working on it. I will inform you how this issue progresses.

[seanmarcia]

Hey @joshleichtung and @Randond I think they should be able to make requests without items provided they have something in the comments. I can see a situation where a partner might send a request with just comments if they were looking for non-standard items. A comment like the following seems possible - "We are helping a teenage girl who was kicked out of her house and are trying to source her a crib, car seat, and a comfortable chair for her to sit in with the baby."

[Randond]

@joshleichtung @seanmarcia I'm having a little trouble with this issue. Do you think you could do a pairing session with me?

[seanmarcia]

@Randond I'm a little packed this weekend but may have some time Monday. Can you push a branch with what you've done so far? I may be able to offer some suggestions!

[Randond]

@seanmarcia Here is a link to a pull request I just made. loyno-mathcs#19

[seanmarcia]

Hey @Randond I took a look and the path you're going down could work but I think there is a simpler solution using rails validations.
You can take a read here about rails validations. I think something like the following should probably do what you're looking for:
validates :items, presence: { unless: :comments? }
Just customize and some tests to confirm it and we should be good to go!

[Randond]

@seanmarcia created new pull request loyno-mathcs#20

[benreyn]

It looks like loyno-mathcs#20 got merged. @seanmarcia @mdworken @armahillo Im going to cherry pick that commit so that..

1. @Randond gets credit for his contribution, and...
2. We can close out this issue

[benreyn]

Fixed in #130