diff --git a/app/views/profiles/show.html.erb b/app/views/profiles/show.html.erb index e45eb5d9f6d..d634606fdbf 100644 --- a/app/views/profiles/show.html.erb +++ b/app/views/profiles/show.html.erb @@ -99,7 +99,7 @@ <%= link_to( truncate(@user.homepage_url,length: 20), - @user.homepage_url, + h(@user.homepage_url), rel: "nofollow", class: "profile__header__attribute t-link--black", data: { confirm: "Are you sure?" } diff --git a/test/system/authorizing_profile_update.rb b/test/system/authorizing_profile_update_test.rb similarity index 95% rename from test/system/authorizing_profile_update.rb rename to test/system/authorizing_profile_update_test.rb index 5f8a328de5c..112eef39c42 100644 --- a/test/system/authorizing_profile_update.rb +++ b/test/system/authorizing_profile_update_test.rb @@ -1,7 +1,7 @@ require "application_system_test_case" require "test_helper" -class AuthorizingProfileUpdate < ApplicationSystemTestCase +class AuthorizingProfileUpdateTest < ApplicationSystemTestCase setup do @user = create(:user, email: "nick@example.com", password: PasswordHelpers::SECURE_TEST_PASSWORD, handle: "nick1", mail_fails: 1) end diff --git a/test/system/profile_test.rb b/test/system/profile_test.rb deleted file mode 100644 index 5afb8195384..00000000000 --- a/test/system/profile_test.rb +++ /dev/null @@ -1,38 +0,0 @@ -require "application_system_test_case" -require "test_helper" - -class ProfileTest < ApplicationSystemTestCase - setup do - @user = create(:user, email: "nick@example.com", password: PasswordHelpers::SECURE_TEST_PASSWORD, handle: "nick1", mail_fails: 1) - end - - def sign_in - visit sign_in_path - fill_in "Email or Username", with: @user.reload.email - fill_in "Password", with: @user.password - click_button "Sign in" - end - - test "adding X(formerly Twitter) username without filling in your password" do - twitter_username = "nick1twitter" - - sign_in - visit profile_path("nick1") - - click_link "Edit Profile" - fill_in "user_twitter_username", with: twitter_username - - assert_equal twitter_username, page.find_by_id("user_twitter_username").value - - click_button "Update" - - # Verify that the newly added Twitter username is still on the form so that the user does not need to re-enter it - assert_equal twitter_username, page.find_by_id("user_twitter_username").value - - fill_in "Password", with: PasswordHelpers::SECURE_TEST_PASSWORD - click_button "Update" - - assert page.has_content? "Your profile was updated." - assert_equal twitter_username, page.find_by_id("user_twitter_username").value - end -end