Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename non-production containers to dev or test for clarification (e.g. fts container) #308

Closed
rdimaio opened this issue Apr 26, 2024 · 1 comment · Fixed by #359
Closed

Rename non-production containers to dev or test for clarification (e.g. fts container) #308

rdimaio opened this issue Apr 26, 2024 · 1 comment · Fixed by #359
Assignees
@rdimaio
Labels
enhancement New feature or request

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Apr 26, 2024 •
edited
Loading

Containers like https://github.com/rucio/containers/tree/master/fts are only meant to be used in demo/test environments, but the container name doesn't explicitly mention this. These containers should be renamed to clarify this point.
@rdimaio rdimaio added the enhancement New feature or request label Apr 26, 2024
@bari12 bari12 assigned rdimaio and unassigned erlingstaff Nov 27, 2024
@rdimaio
Copy link
Contributor Author

rdimaio commented Nov 27, 2024

naming convention agreed on: test-[containername] (this way they are also close together when sorted alphabetically)

@rdimaio rdimaio linked a pull request Nov 30, 2024 that will close this issue
Rename test containers to have the 'test-' prefix #359
Merged
rdimaio added a commit to rdimaio/rucio that referenced this issue Jan 28, 2025
@rdimaio
Testing: Rename test containers to test-prefix
3bc0572 
Renaming containers according to this PR: rucio/containers#359
See also: rucio/containers#308

Note: the tests are expected to fail until rucio/containers#359 is merged.
rdimaio added a commit to rdimaio/rucio that referenced this issue Jan 28, 2025
@rdimaio
Testing: Rename test containers to test-prefix
6ffa70f 
Renaming containers according to this PR: rucio/containers#359
See also: rucio/containers#308

Note: the tests are expected to fail until rucio/containers#359 is merged.
@rdimaio rdimaio mentioned this issue Jan 28, 2025
Open
rdimaio added a commit to rdimaio/rucio-k8s-tutorial that referenced this issue Jan 28, 2025
@rdimaio
Testing: Rename test containers to test-prefix
bb805ca 
Renaming containers according to this PR: rucio/containers#359
See also: rucio/containers#308
@rdimaio rdimaio mentioned this issue Jan 28, 2025
Open
@rdimaio rdimaio removed a link to a pull request Feb 6, 2025
Rename test containers to have the 'test-' prefix #359
Merged
@bari12 bari12 linked a pull request Feb 7, 2025 that will close this issue
Rename test containers to have the 'test-' prefix #359
Merged
@bari12 bari12 reopened this Feb 7, 2025
@bari12 bari12 closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdimaio rdimaio

Labels
enhancement New feature or request
Projects
Rucio 37 “Dungeons & Donkeys” release roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename test containers to have the 'test-' prefix rdimaio/rucio-containers
3 participants
@bari12 @rdimaio @erlingstaff