From f570d038bbc0bb9dd66e4b204e5ba53080315981 Mon Sep 17 00:00:00 2001 From: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Date: Fri, 24 Jan 2025 12:30:50 +0530 Subject: [PATCH] chore: add custom domain url labels for gtm and ga4 (#1867) --- src/configurations/destinations/ga4/ui-config.json | 4 ++-- src/configurations/destinations/gtm/ui-config.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/configurations/destinations/ga4/ui-config.json b/src/configurations/destinations/ga4/ui-config.json index d5b0ac730..8c6125625 100644 --- a/src/configurations/destinations/ga4/ui-config.json +++ b/src/configurations/destinations/ga4/ui-config.json @@ -123,11 +123,11 @@ ], "condition": "or" }, - "label": "SDK Base URL", + "label": "Custom Domain URL", "configKey": "sdkBaseUrl", "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$", "regexErrorMessage": "Please input a valid URL.", - "note": "Enter your GA4 SDK base URL, https://{SDK Base URL}/gtag/js. By default, it is https://www.googletagmanager.com.", + "note": "Enter your GA4 Custom Domain URL, https://{Custom Domain URL}/gtag/js. By default, it is https://www.googletagmanager.com.", "placeholder": "e.g: https://www.example.com", "default": "https://www.googletagmanager.com", "secret": false diff --git a/src/configurations/destinations/gtm/ui-config.json b/src/configurations/destinations/gtm/ui-config.json index 0fe1d3b44..71e65d708 100644 --- a/src/configurations/destinations/gtm/ui-config.json +++ b/src/configurations/destinations/gtm/ui-config.json @@ -14,7 +14,7 @@ }, { "type": "textInput", - "label": "Server Container URL", + "label": "Custom Domain URL", "value": "serverUrl", "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$", "regexErrorMessage": "Invalid URL",