From 94cab5782823a758ddd33973f9bd2d4daecd85ba Mon Sep 17 00:00:00 2001
From: gshaibi <gshaibi@gmail.com>
Date: Tue, 16 Jul 2024 12:02:51 +0300
Subject: [PATCH] PR fixes

---
 deploy/fake-gpu-operator/values.yaml            |  2 +-
 internal/status-updater/handlers/node/labels.go | 13 +++++++++----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/deploy/fake-gpu-operator/values.yaml b/deploy/fake-gpu-operator/values.yaml
index d6d1653..a740a22 100644
--- a/deploy/fake-gpu-operator/values.yaml
+++ b/deploy/fake-gpu-operator/values.yaml
@@ -72,4 +72,4 @@ topology:
       gpuCount: 2
       gpuMemory: 11441
   nodePoolLabelKey: run.ai/simulated-gpu-node-pool
-  mig-strategy: mixed
\ No newline at end of file
+  migStrategy: mixed
\ No newline at end of file
diff --git a/internal/status-updater/handlers/node/labels.go b/internal/status-updater/handlers/node/labels.go
index 7a5a0ab..f05315a 100644
--- a/internal/status-updater/handlers/node/labels.go
+++ b/internal/status-updater/handlers/node/labels.go
@@ -10,11 +10,16 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 )
 
+const (
+	dcgmExporterLabelKey = "nvidia.com/gpu.deploy.dcgm-exporter"
+	devicePluginLabelKey = "nvidia.com/gpu.deploy.device-plugin"
+)
+
 // labelNode labels the node with required labels for the fake-gpu-operator to function.
 func (p *NodeHandler) labelNode(node *v1.Node) error {
 	err := p.patchNodeLabels(node, map[string]interface{}{
-		"nvidia.com/gpu.deploy.dcgm-exporter": "true",
-		"nvidia.com/gpu.deploy.device-plugin": "true",
+		dcgmExporterLabelKey: "true",
+		devicePluginLabelKey: "true",
 	})
 	if err != nil {
 		return fmt.Errorf("failed to label node %s: %w", node.Name, err)
@@ -26,8 +31,8 @@ func (p *NodeHandler) labelNode(node *v1.Node) error {
 // unlabelNode removes the labels from the node that were added by the fake-gpu-operator.
 func (p *NodeHandler) unlabelNode(node *v1.Node) error {
 	err := p.patchNodeLabels(node, map[string]interface{}{
-		"nvidia.com/gpu.deploy.dcgm-exporter": nil,
-		"nvidia.com/gpu.deploy.device-plugin": nil,
+		dcgmExporterLabelKey: nil,
+		devicePluginLabelKey: nil,
 	})
 	if err != nil {
 		return fmt.Errorf("failed to unlabel node %s: %w", node.Name, err)