Add functionality for cluster.kill.
#1588
Merged
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
carolineechen
approved these changes
Dec 12, 2024
| process (str): Process to kill. | ||
|
|
||
| Example: | ||
| >>> rh.cluster("rh-cpu").kill("ray") |
There was a problem hiding this comment.
nit - maybe use a diff string (that's not also a package) for the example?
| @@ -1228,3 +1228,14 @@ def test_cluster_run_bash_in_process(self, cluster): | |||
| res = cluster.run_bash("echo hello", process=process) | |||
| assert res[0][0] == 0 | |||
| assert res[0][1].strip() == "hello" | |||
|
|
|||
| @pytest.mark.level("local") | |||
| @pytest.mark.clustertest | |||
There was a problem hiding this comment.
there's 2 existing tests in test_cluster depending on this feature that I marked as skip - can you address those too? either update or remove them if this test covers it (marked with @pytest.mark.skip("pending cluster.kill functionality"))
rohinb2
changed the base branch from
12-12-remove_another_cluster.run_
to
graphite-base/1588
rohinb2
force-pushed
the
12-12-add_functionality_for_cluster.kill_
branch
from
26b26e1 to
3ada528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.