Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create CONTRIBUTING.md #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vsiravar
Copy link
Contributor

Signed-off-by: Vishwas Siravara [email protected]

Issue #, if available:
2
Description of changes:
Add CONTRIBUTING.md file for contributing guidelines.

Testing done:
N/A

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment, LGTM otherwise!

## Find an Issue

We have good first issues for new contributors and help wanted issues suitable
for any contributor. [good first issue](TODO) has extra information to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the "good first issue" and "help wanted" links? Nit: also might want to sentence case them (so like "Good first issue"), just because they're right after a period. I think the casing is probably off in other repos too though so this isn't a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants