Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in pyk integration tests #3662

Closed
tothtamas28 opened this issue Sep 21, 2023 · 2 comments · Fixed by runtimeverification/pyk#649
Closed

Regression in pyk integration tests #3662

tothtamas28 opened this issue Sep 21, 2023 · 2 comments · Fixed by runtimeverification/pyk#649
Assignees

Comments

@tothtamas28
Copy link
Contributor

Analysis: runtimeverification/pyk#649 (comment)

@ehildenb
Copy link
Member

If we can't make progress on the issue directly, we can consider reverting the PR which caused this problem (#3650). That revert should be tested downstream before committing to it though, because if reverting it causes other regressions, we need to make sure we have workarounds for those other regressions.

@geo2a
Copy link
Collaborator

geo2a commented Sep 21, 2023

The problem was in the fact we've returned a "branching" result with only one branch, which pyk interpreted as "stuck".

It turns out, Sam ahs already made a subsequent patch (#3653) to HB, and I've completely forgotten about it. I've approved the dependency update to K (runtimeverification/k#3633) which would merge it. Once this change propagates here, the test will be green again.

I've verified locally by doing:

kup install k --version 06734ea77b9ed0037619d81cf193cb1198701f2a
cd pyk
make test-integration TEST_ARGS='-k imp-simple-sum-loop'

@tothtamas28 we can keep this open until the update propagates from K to pyk.

tothtamas28 pushed a commit to runtimeverification/pyk that referenced this issue Sep 27, 2023
Closes
runtimeverification/haskell-backend#3662

~Blocked by: runtimeverification/k#3646

---------

Co-authored-by: devops <[email protected]>
Co-authored-by: Everett Hildenbrandt <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this issue Apr 9, 2024
Closes
runtimeverification/haskell-backend#3662

~Blocked by: #3646

---------

Co-authored-by: devops <[email protected]>
Co-authored-by: Everett Hildenbrandt <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this issue Apr 9, 2024
Closes
runtimeverification/haskell-backend#3662

~Blocked by: #3646

---------

Co-authored-by: devops <[email protected]>
Co-authored-by: Everett Hildenbrandt <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this issue Apr 9, 2024
Baltoli pushed a commit to runtimeverification/k that referenced this issue Apr 10, 2024
Baltoli pushed a commit to runtimeverification/k that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants