-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Booster's and Kore's "implies"
endpoints disagree on a pyk
integration test
#3857
Comments
I suspect checking whether the antecedent/consequent is #Bottom will negate any speed gains we got from implementing the simple implication check, as this would just be a call to the kore simplifier anyway :/ |
I agree that simplifying both antecedent and consequent would probably kill the performance. Perhaps we need to re-think the how we use the implies endpoint a little. As I understand, we currently have two use-cases for it:
Perhaps we could indeed implement @ehildenb original idea and have two endpoints: a lightweight "simplify-implication" (or some other name), and a the old "implies". The lightweight one will have additional assumptions:
the old |
~Blocked on runtimeverification/haskell-backend#3857 ~Blocked on runtimeverification/haskell-backend#3876 --------- Co-authored-by: devops <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Guy Repta <[email protected]>
We should use a basic ceil checker in booster to re-enable the new implication endpoint and port the pyk tests into booster to check that the new implication endpoint can handle them correctly. |
The HB update pr to K fails two
pyk
integrations tests:In the first test, Booster returns a non-empty substitution and an empty predicate, while Kore returns an empty substitution and
#Bottom
as predicate, which is also the expected output.In the second test, an error response (indicated by an exception in
KoreClient
) is expected, but no exception is raised. I've modified test to compare the output toNone
in order to see the responses:this reveals that Kore returns an error, while Booster does not.
The text was updated successfully, but these errors were encountered: